[ 
https://issues.apache.org/jira/browse/YARN-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135652#comment-16135652
 ] 

ASF GitHub Bot commented on YARN-2162:
--------------------------------------

Github user flyrain commented on a diff in the pull request:

    https://github.com/apache/hadoop/pull/261#discussion_r134311049
  
    --- Diff: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/AllocationFileLoaderService.java
 ---
    @@ -495,17 +496,17 @@ private void loadQueue(String parentName, Element 
element,
           Element field = (Element) fieldNode;
           if ("minResources".equals(field.getTagName())) {
             String text = ((Text)field.getFirstChild()).getData().trim();
    -        Resource val =
    +        ResourceConfiguration val =
    --- End diff --
    
    The major usage of min share is sorting schedulables and preemption. I 
didn't see many cons. In the other side,
    the needs for min share as percentage are limited. It shouldn't a common 
case that a job/queue says to RM that no matter how much resource you have, I 
need at least 10% of them. Make min share as percentage isn't necessary as 
well. Hence, we could just leave it alone.


> add ability in Fair Scheduler to optionally configure maxResources in terms 
> of percentage
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-2162
>                 URL: https://issues.apache.org/jira/browse/YARN-2162
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler, scheduler
>            Reporter: Ashwin Shankar
>            Assignee: Yufei Gu
>              Labels: scheduler
>         Attachments: YARN-2162.001.patch, YARN-2162.002.patch
>
>
> minResources and maxResources in fair scheduler configs are expressed in 
> terms of absolute numbers X mb, Y vcores. 
> As a result, when we expand or shrink our hadoop cluster, we need to 
> recalculate and change minResources/maxResources accordingly, which is pretty 
> inconvenient.
> We can circumvent this problem if we can optionally configure these 
> properties in terms of percentage of cluster capacity. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to