[ 
https://issues.apache.org/jira/browse/YARN-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16137944#comment-16137944
 ] 

zhangshilong edited comment on YARN-4090 at 8/23/17 6:17 AM:
-------------------------------------------------------------

[[email protected]] [~yufeigu]  Never mind. It is my fault. 




was (Author: zsl2007):
[[email protected]] [~yufeigu]  Never mind. It is my fault. 
I patch v7   
In FSAppAttmept.java  function "containerCompleted" can be called by RM 
preemption,AM release and NM release.
 RM preemption is considered in Patch v7. But AM and NM may also release same 
container.
So in my thought,
{code:java}
 // Remove from the list of containers
 RMContainer removedContainer = 
liveContainers.remove(rmContainer.getContainerId());
 if(removedContainer != null){
      this.fsQueue.decResourceUsage(removedContainer.getAllocatedResource());
 }
{code}


> Make Collections.sort() more efficient by caching resource usage
> ----------------------------------------------------------------
>
>                 Key: YARN-4090
>                 URL: https://issues.apache.org/jira/browse/YARN-4090
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: fairscheduler
>            Reporter: Xianyin Xin
>            Assignee: zhangshilong
>         Attachments: sampling1.jpg, sampling2.jpg, YARN-4090.001.patch, 
> YARN-4090.002.patch, YARN-4090.003.patch, YARN-4090.004.patch, 
> YARN-4090.005.patch, YARN-4090.006.patch, YARN-4090.007.patch, 
> YARN-4090-preview.patch, YARN-4090-TestResult.pdf
>
>
> Collections.sort() consumes too much time in a scheduling round.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to