[ 
https://issues.apache.org/jira/browse/YARN-7057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16140723#comment-16140723
 ] 

Daniel Templeton commented on YARN-7057:
----------------------------------------

Yep, capacity scheduler failure is unrelated.  Looks like a generally sane 
change to me.  Quick question, though: why the change to 
{{getResourceUsage()}}?  That change would seem to have a pretty large impact.  
For example, also in {{FSAppAttempt}}:{code}  Resource getPendingDemand() {
    return Resources.subtract(demand, getResourceUsage());
  }{code}  Are we sure that change isn't going to cause problems?

> FSAppAttempt#getResourceUsage doesn't need to consider resources queued for 
> preemption
> --------------------------------------------------------------------------------------
>
>                 Key: YARN-7057
>                 URL: https://issues.apache.org/jira/browse/YARN-7057
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler
>    Affects Versions: 2.9.0
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>         Attachments: YARN-7057.001.patch
>
>
> FSAppAttempt#getResourceUsage excludes resources that are currently allocated 
> to the app but are about to be preempted. This inconsistency shows in the UI 
> and can affect scheduling of containers. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to