[ 
https://issues.apache.org/jira/browse/YARN-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16143875#comment-16143875
 ] 

Billie Rinaldi commented on YARN-7091:
--------------------------------------

I found just a couple of uses of app that were missed in the docs, so I will 
fix these before committing:
{code}
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Simplified-V1-API-Layer-For-Services.yaml
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Simplified-V1-API-Layer-For-Services.yaml
index 066a4d8..bc2a668 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Simplified-V1-API-Layer-For-Services.yaml
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services-api/src/main/resources/definition/YARN-Simplified-V1-API-Layer-For-Services.yaml
@@ -211,7 +211,7 @@ definitions:
         description: The YARN queue that this service should be submitted to.
   Resource:
     description:
-      Resource determines the amount of resources (vcores, memory, network, 
etc.) usable by a container. This field determines the resource to be applied 
for all the containers of a component or service. The resource specified at the 
app (or global) level can be overriden at the component level. Only one of 
profile OR cpu & memory are exepected. It raises a validation exception 
otherwise.
+      Resource determines the amount of resources (vcores, memory, network, 
etc.) usable by a container. This field determines the resource to be applied 
for all the containers of a component or service. The resource specified at the 
service (or global) level can be overriden at the component level. Only one of 
profile OR cpu & memory are exepected. It raises a validation exception 
otherwise.
     properties:
       profile:
         type: string
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/PlacementPolicy.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/PlacementPolicy.java
index 24bfc76..6f6fe6f 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/PlacementPolicy.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/PlacementPolicy.java
@@ -41,10 +41,10 @@
   private String label = null;
 
   /**
-   * Assigns an app to a named partition of the cluster where the service
-   * desires to run (optional). If not specified all apps are submitted to a
-   * default label of the app owner. One or more labels can be setup for each
-   * service owner account with required constraints like no-preemption,
+   * Assigns a service to a named partition of the cluster where the service
+   * desires to run (optional). If not specified all services are submitted to
+   * a default label of the service owner. One or more labels can be setup for
+   * each service owner account with required constraints like no-preemption,
    * sla-99999, preemption-ok, etc.
    **/
   public PlacementPolicy label(String label) {
@@ -52,7 +52,7 @@ public PlacementPolicy label(String label) {
     return this;
   }
 
-  @ApiModelProperty(example = "null", value = "Assigns a app to a named 
partition of the cluster where the service desires to run (optional). If not 
specified all services are submitted to a default label of the service owner. 
One or more labels can be setup for each service owner account with required 
constraints like no-preemption, sla-99999, preemption-ok, etc.")
+  @ApiModelProperty(example = "null", value = "Assigns a service to a named 
partition of the cluster where the service desires to run (optional). If not 
specified all services are submitted to a default label of the service owner. 
One or more labels can be setup for each service owner account with required 
constraints like no-preemption, sla-99999, preemption-ok, etc.")
   @JsonProperty("label")
   public String getLabel() {
     return label;
diff --git 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Resource.java
 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Resource.java
index 5ed2071..c252d1a 100644
--- 
a/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Resource.java
+++ 
b/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core/src/main/java/org/apache/hadoop/yarn/service/api/records/Resource.java
@@ -36,7 +36,7 @@
  **/
 @InterfaceAudience.Public
 @InterfaceStability.Unstable
-@ApiModel(description = "Resource determines the amount of resources (vcores, 
memory, network, etc.) usable by a container. This field determines the 
resource to be applied for all the containers of a component or service. The 
resource specified at the app (or global) level can be overriden at the 
component level. Only one of profile OR cpu & memory are exepected. It raises a 
validation exception otherwise.")
+@ApiModel(description = "Resource determines the amount of resources (vcores, 
memory, network, etc.) usable by a container. This field determines the 
resource to be applied for all the containers of a component or service. The 
resource specified at the service (or global) level can be overriden at the 
component level. Only one of profile OR cpu & memory are exepected. It raises a 
validation exception otherwise.")
 @javax.annotation.Generated(value = "class 
io.swagger.codegen.languages.JavaClientCodegen", date = 
"2016-06-02T08:15:05.615-07:00")
 public class Resource extends BaseResource implements Cloneable {
   private static final long serialVersionUID = -6431667797380250037L;
{code}

> Rename application to service in yarn-native-services
> -----------------------------------------------------
>
>                 Key: YARN-7091
>                 URL: https://issues.apache.org/jira/browse/YARN-7091
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Jian He
>            Assignee: Jian He
>         Attachments: YARN-7091.yarn-native-services.01.patch, 
> YARN-7091.yarn-native-services.02.patch, 
> YARN-7091.yarn-native-services.03.patch, 
> YARN-7091.yarn-native-services.04.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to