[ 
https://issues.apache.org/jira/browse/YARN-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16144268#comment-16144268
 ] 

Junping Du commented on YARN-7076:
----------------------------------

Thanks [~jianhe] for delivering a quick fix. The patch looks general OK to me. 
A minor issue here is we better to add a UT to test ClientRMService is case 
insensitive now - a simple way is to add something similar to below code in 
TestClientRMService.java but using all upper case or/and lower case of 
"matchType".

{noformat}
    Set<String> appTypes = new HashSet<String>();
    appTypes.add("matchType");

    getAllAppsRequest = GetApplicationsRequest.newInstance(appTypes);
    getAllApplicationsResponse =
        rmService.getApplications(getAllAppsRequest);
    Assert.assertEquals(1,
        getAllApplicationsResponse.getApplicationList().size());
{noformat}

> yarn application -list -appTypes <appType> is not working
> ---------------------------------------------------------
>
>                 Key: YARN-7076
>                 URL: https://issues.apache.org/jira/browse/YARN-7076
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Jian He
>            Assignee: Jian He
>            Priority: Blocker
>         Attachments: YARN-7076.01.patch
>
>
> yarn application -list -appTypes <appType> is not working
> Looks like it's because the ApplicationCLI pass in the appType as uppercase, 
> but ClientRMService#getApplications is case sensitive, so if user submits an 
> app with lowercase appType, it wont work



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to