[ 
https://issues.apache.org/jira/browse/YARN-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725530#comment-13725530
 ] 

Vinod Kumar Vavilapalli commented on YARN-1004:
-----------------------------------------------

bq.  maximum-allocation is just for consistency. My thought is that it should 
be scheduler-specific because it's up to the scheduler to honor the config. 
Someone could write a new scheduler and not handle it.
I haven't been following the FifoScheduler changes but this is wrong. All 
schedulers should honor this. Otherwise app-writers won't know what can be 
honoured and what cannot be.

Seems like it is already agreed that min is specific to scheduler. Even there 
I'd make the same argument.
                
> yarn.scheduler.minimum|maximum|increment-allocation-mb should have scheduler
> ----------------------------------------------------------------------------
>
>                 Key: YARN-1004
>                 URL: https://issues.apache.org/jira/browse/YARN-1004
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 2.1.0-beta
>            Reporter: Sandy Ryza
>
> As yarn.scheduler.minimum-allocation-mb is now a scheduler-specific 
> configuration, and functions differently for the Fair and Capacity 
> schedulers, it would be less confusing for the config names to include the 
> scheduler names, i.e. yarn.scheduler.fair.minimum-allocation-mb, 
> yarn.scheduler.capacity.minimum-allocation-mb, and 
> yarn.scheduler.fifo.minimum-allocation-mb.
> The same goes for yarn.scheduler.increment-allocation-mb, which only exists 
> for the Fair Scheduler, and yarn.scheduler.maximum-allocation-mb, for 
> consistency.
> If we wish to preserve backwards compatibility, we can deprecate the old 
> configs to the new ones. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to