[ 
https://issues.apache.org/jira/browse/YARN-985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725610#comment-13725610
 ] 

Ravi Prakash commented on YARN-985:
-----------------------------------

Hi Omkar!
bq.  yeah this is a small thing but would have preferred logging in successful 
state transition
Is there a reason for your preference? The reason I put it there was because 
this way I am piggybacking on an already existing Log statement. Granted it 
shouldn't be much of a performance bottleneck (unless its a fat node launching 
a lot of containers which are localizing a lot of files), but there's a 
tangible reason for why I chose to do it that way. Even logging has performance 
implications as we saw in HDFS-4080.

bq. You can also have a debug log when file gets removed from cache to see if 
it is deleted or not. LocalResourcesTrackerImpl.java
I'm sorry I missed your suggestion in the original post. That's a good 
suggestion. I'll update the patch to Log.info() when it removes the 
LocalizedResource.
                
> Nodemanager should log where a resource was localized
> -----------------------------------------------------
>
>                 Key: YARN-985
>                 URL: https://issues.apache.org/jira/browse/YARN-985
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>    Affects Versions: 3.0.0, 2.0.4-alpha, 0.23.9
>            Reporter: Ravi Prakash
>            Assignee: Ravi Prakash
>         Attachments: YARN-985.patch
>
>
> When a resource is localized, we should log WHERE on the local disk it was 
> localized. This helps in debugging afterwards (e.g. if the disk was to go 
> bad).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to