[ 
https://issues.apache.org/jira/browse/YARN-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145386#comment-16145386
 ] 

Sunil G commented on YARN-7033:
-------------------------------

Thanks [~devaraj.k] and [~leftnoteasy]

Some quick comments:
# In Container or ContainerImpl, its better to add a javadoc for 
*getResourceMappings*
# One doubt about {{storeAssignedResources}}, in which event this method ll be 
invoked ?
# In general {{String resourceType}} could be an ENUM so that it may be easier 
to operate, thoughts?

> Add support for NM Recovery of assigned resources(GPU's, NUMA, FPGA's) to 
> container
> -----------------------------------------------------------------------------------
>
>                 Key: YARN-7033
>                 URL: https://issues.apache.org/jira/browse/YARN-7033
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Devaraj K
>            Assignee: Devaraj K
>         Attachments: YARN-7033-v0.patch, YARN-7033-v1.patch
>
>
> This JIRA adds the common logic to store the assigned resources to container 
> such as GPU's(YARN-6620), NUMA(YARN-5764) and FPGA's(YARN-5983) etc. and 
> recover upon restart of NM.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to