[
https://issues.apache.org/jira/browse/YARN-573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13725909#comment-13725909
]
Omkar Vinit Joshi commented on YARN-573:
----------------------------------------
Thanks [~jlowe] and [~sjlee0] for reviewing..
Fixed the comments..
[~sjlee0] yes ConcurrentLinkedQueue will solve this synchronization issue
altogether. I am planning to restructure it a lot when we end up fixing
YARN-574. Today update method is making 2 calls to findNextResources which
ideally should be one. After that the whole code itself will get simplified a
lot ..Also inside findNextResources we are repeatedly checking for the same set
of resources (list) again and again until the resource gets downloaded.. which
ideally should only be done once....yes but this is out of the scope for this
jira...will definitely address it on another jira. (YARN-574)
> Shared data structures in Public Localizer and Private Localizer are not
> Thread safe.
> -------------------------------------------------------------------------------------
>
> Key: YARN-573
> URL: https://issues.apache.org/jira/browse/YARN-573
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Omkar Vinit Joshi
> Assignee: Omkar Vinit Joshi
> Priority: Critical
> Attachments: YARN-573-20130730.1.patch, YARN-573-20130731.1.patch
>
>
> PublicLocalizer
> 1) pending accessed by addResource (part of event handling) and run method
> (as a part of PublicLocalizer.run() ).
> PrivateLocalizer
> 1) pending accessed by addResource (part of event handling) and
> findNextResource (i.remove()). Also update method should be fixed. It too is
> sharing pending list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
