[
https://issues.apache.org/jira/browse/YARN-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Varun Vasudev updated YARN-6623:
--------------------------------
Attachment: YARN-6623.007.patch
Thanks for the additional feedback [~ebadger] and [~leftnoteasy]!
{quote}
As an additional comment on my second pass, I don’t think need to call
normalize_mounts() up front since values might not have anything in it. Also,
we might have only RO or only RW mounts, so we don’t need to necessarily
compute permitted_rw or permitted_ro. We only need to if we’re actually going
to mount RW or RO respectively.
{quote}
Makes sense. Fixed.
{quote}
Just one quick comment: for feature enable/disable. I suggest to put under
section.
For GPU feature (YARN-6852), I made config like:
\[gpu]
# Enable / disable the module
module.enabled=true/false
If you're OK with the style, I suggest to make it consistent: You can use
module-configs.h to call module_enabled and get the config.
{quote}
Fixed.
bq. And what is feature tc? Could you make the feature name more descriptive?
tc is the traffic control piece for network throttling. I'll fix the
documentation in a follow up patch.
> Add support to turn off launching privileged containers in the
> container-executor
> ---------------------------------------------------------------------------------
>
> Key: YARN-6623
> URL: https://issues.apache.org/jira/browse/YARN-6623
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager
> Reporter: Varun Vasudev
> Assignee: Varun Vasudev
> Priority: Blocker
> Attachments: YARN-6623.001.patch, YARN-6623.002.patch,
> YARN-6623.003.patch, YARN-6623.004.patch, YARN-6623.005.patch,
> YARN-6623.006.patch, YARN-6623.007.patch
>
>
> Currently, launching privileged containers is controlled by the NM. We should
> add a flag to the container-executor.cfg allowing admins to disable launching
> privileged containers at the container-executor level.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
