[ 
https://issues.apache.org/jira/browse/YARN-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16147573#comment-16147573
 ] 

Daniel Templeton commented on YARN-7123:
----------------------------------------

Looks generally good.  Before we go fixing the issue, that, I'd like some 
independent verification that the issue is really an issue.  On the patch, 
please add a default to the docs for the new property.  Also, it would be 
better to add a default class to {{FairSchedulerConfiguration}} than to add the 
dependency on {{CapacitySchedulerConfiguration}}.

> FairScheduler.getResourceCalculator() returns an instance of 
> DefaultResourceCalculator regardless of the configuration
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7123
>                 URL: https://issues.apache.org/jira/browse/YARN-7123
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: fairscheduler
>    Affects Versions: 3.0.0-alpha4
>            Reporter: Daniel Templeton
>         Attachments: YARN-7123.branch-3.0.0-alpha4.001.patch
>
>
> There are several places where this creates the wrong behavior:
> * 298:RMServerUtils.java
> * 1081:AbstractYarnScheduler.java
> * 1197:FSAppAttempt.java



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to