[ 
https://issues.apache.org/jira/browse/YARN-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bibin A Chundatt updated YARN-6727:
-----------------------------------
    Attachment: YARN-6727.005.patch

Thank you [~sunilg] for review comments
{quote}
I think we can keep apis in GetQueueUserAclsInfoRequest as Unstable. Or were 
there any other discussion on same?
{quote}
Currently is stable and the way i understand about stable and unstable we can 
keep it same
{code}
Stable
   * Can evolve while retaining compatibility for minor release boundaries.; 
   * can break compatibility only at major release (ie. at m.0).
Unstable
   * No guarantee is provided as to reliability or stability across any
   * level of release granularity.
{code}

{quote}
If we use an old client List<String> queueNames = request.getQueueNames(); 
could come as NULL. ref ClientRMService#getQueueUserAcls
{quote}
IIUC repeated the default value should be EMPTY list .
{code}
    private void initFields() {
      queueNames_ = com.google.protobuf.LazyStringArrayList.EMPTY;
      userName_ = "";
    }
{code}

All other comments are handled. 

> Improve getQueueUserAcls API to query for  specific queue and user
> ------------------------------------------------------------------
>
>                 Key: YARN-6727
>                 URL: https://issues.apache.org/jira/browse/YARN-6727
>             Project: Hadoop YARN
>          Issue Type: Improvement
>            Reporter: Bibin A Chundatt
>            Assignee: Bibin A Chundatt
>         Attachments: YARN-6727.001.patch, YARN-6727.002.patch, 
> YARN-6727.003.patch, YARN-6727.004.patch, YARN-6727.005.patch, 
> YARN-6727.WIP.patch
>
>
> Currently {{ApplicationClientProtocol#getQueueUserAcls}} return data for all 
> the queues available in scheduler for user.
> User wants to know whether he has rights of a particular queue only. For 
> systems with 5K queues returning all queues list is not efficient.
> Suggested change: support additional parameters *userName and queueName* as 
> optional. Admin user should be able to query other users ACL for a particular 
> queueName.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to