[ https://issues.apache.org/jira/browse/YARN-6600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16154735#comment-16154735 ]
Sunil G commented on YARN-6600: ------------------------------- Thanks [~rohithsharma] Some more minor nits: # In {{UpdateApplicationTimeoutsResponsePBImpl #setApplicationTimeouts}}, IIUC *applicationTimeouts* needs to be cleared when *appTimeouts* is null. # {{@param lifetime requestedByApp}} could be {{lifetime configured application lifetime}} # Since below variables are in LeafQueue, could we add Application also in variable name. {code} private volatile long maxLifetime = -1; private volatile long defaultLifetime = -1; {code} like maxApplicationLifetime and defaultApplicationLifetime # It ll be fine to add one test case for other schedulers to ensure the feature is not switched on. > Enhance default lifetime of application at LeafQueue level. > ----------------------------------------------------------- > > Key: YARN-6600 > URL: https://issues.apache.org/jira/browse/YARN-6600 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacity scheduler > Reporter: Rohith Sharma K S > Assignee: Rohith Sharma K S > Attachments: YARN-6600.01.patch, YARN-6600.02.patch, > YARN-6600.03.patch, [YARN-6600] Extend lifetime to scheduler Leaf Queue.pdf > > > Setting timeout at LeafQueue level allows admin to control from bad apps > which uses most of the resources for all the time. > Example : Any application submitted to particular queue i.e QUEUE-1 should > not run more than N hours. Even user set lifetime as N+1 hour, the > application will be killed after N hours. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org