[
https://issues.apache.org/jira/browse/YARN-6978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156217#comment-16156217
]
Arun Suresh commented on YARN-6978:
-----------------------------------
Thanks for the patch [~kartheek]..
We have to ensure that callers of the {{increaseContainerResourceAsync}} method
still get callbacks via {{onIncreaseContainerResourceError}} and
{{onContainerResourceIncreased}}. This means that:
* In the {{NMClientAsyncImpl::increaseContainerResourceAsync()}} method, in
line 270 and 281 you should still call
{{handler.onIncreaseContainerResourceError(..)}}
* The new {{UpdateContainerResourceEvent}} should probably take a boolean flag
in the constructor to say is an *increase* event (since there is no way to
figure that out otherwise), so in line 277, where you do {{events.put(new
UpdateContainerResourceEvent(container))}}, you should also pass the flag. This
flag can then later be used in {{UpdateContainerResourceTransition}} to call
{{handler.onContainerResourceIncreased/onIncreaseContainerResourceError}} if
true, else call
{{handler.onContainerResourceUpdated/onUpdateContainerResourceError}}
> Add updateContainer API to NMClient.
> ------------------------------------
>
> Key: YARN-6978
> URL: https://issues.apache.org/jira/browse/YARN-6978
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun Suresh
> Assignee: kartheek muthyala
> Attachments: YARN-6978.001.patch
>
>
> This is to track the addition of updateContainer API to the {{NMClient}} and
> {{NMClientAsync}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
