[ 
https://issues.apache.org/jira/browse/YARN-5330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157459#comment-16157459
 ] 

Subru Krishnan commented on YARN-5330:
--------------------------------------

Thanks [~curino] for the patch. It looks good except for couple of nits:
* Can you remove the commented code in {{CapacityOverTimePolicy}} as now we 
handle periodicity in {{RLESparseResourceAllocation}} transparently.
* Fix the remaining checkstyle warnings.

BTW I really like the {{BaseSharingPolicyTest}} refactoring.


> SharingPolicy enhancements required to support recurring reservations in the 
> YARN ReservationSystem
> ---------------------------------------------------------------------------------------------------
>
>                 Key: YARN-5330
>                 URL: https://issues.apache.org/jira/browse/YARN-5330
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>            Reporter: Subru Krishnan
>            Assignee: Carlo Curino
>         Attachments: YARN-5330.v0.patch, YARN-5330.v1.patch, 
> YARN-5330.v2.patch, YARN-5330.v3.patch, YARN-5330.v4.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the 
> YARN ReservationSystem. This JIRA is a sub-task to track the changes required 
> in SharingPolicy to accomplish it. Please refer to the design doc in the 
> parent JIRA for details.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to