[
https://issues.apache.org/jira/browse/YARN-5329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157474#comment-16157474
]
Subru Krishnan commented on YARN-5329:
--------------------------------------
Thanks [~curino] for working on this. The patch looks straightforward.
Couple of nits:
* In {{PlanningAlgorithm}}, check for null before parsing the
_recurrenceExpression_.
* Again, I really like the {{TestReservationAgents}} but why are we not
initializing the parameters in respective tests as is done in
{{BaseSharingPolicyTest}}?
* Fix the checkstyle (naming) and whitespace Yetus warnings.
> ReservationAgent enhancements required to support recurring reservations in
> the YARN ReservationSystem
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-5329
> URL: https://issues.apache.org/jira/browse/YARN-5329
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Subru Krishnan
> Assignee: Carlo Curino
> Attachments: YARN-5329.v0.patch, YARN-5329.v1.patch,
> YARN-5329.v2.patch
>
>
> YARN-5326 proposes adding native support for recurring reservations in the
> YARN ReservationSystem. This JIRA is a sub-task to track the changes required
> in ReservationAgent to accomplish it. Please refer to the design doc in the
> parent JIRA for details.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
