[ 
https://issues.apache.org/jira/browse/YARN-956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13726873#comment-13726873
 ] 

Zhijie Shen commented on YARN-956:
----------------------------------

One more thought about HistoryStorage. Does HistoryStorage need to extend 
AbstractService, such that we can make use of the life cycle: init() can be 
used to prepare the storage and stop() can be used to release the storage. For 
In-memory HistoryStorage, these two steps may be not necessary, because the 
memory will be eventually released by GC. However, FileSystem HistoryStorage 
will need these two steps (see YARN-975). However, I think it's good to be 
consistent among all the implementations. Other implementations, such as DB 
HistoryStorage, may also need to the steps to setup the connection and to 
disconnect. Thoughts?
                
> [YARN-321] Add History Store interface and testable in-memory HistoryStorage
> ----------------------------------------------------------------------------
>
>                 Key: YARN-956
>                 URL: https://issues.apache.org/jira/browse/YARN-956
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Mayank Bansal
>         Attachments: YARN-956-1.patch, YARN-956-2.patch, YARN-956-3.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to