[
https://issues.apache.org/jira/browse/YARN-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159977#comment-16159977
]
Daniel Templeton commented on YARN-7172:
----------------------------------------
Nice. Looks like you did a good job of removing the cluster parameter all the
way up the stack when it was only being used for {{fitsIn()}}. My only ask is
that you clean up the spacing. There are lots of places where removing the
{{cluster}} parameter makes it possible to compress lines or slide something
from the next line back into that space.
> ResourceCalculator.fitsIn() should not take a cluster resource parameter
> ------------------------------------------------------------------------
>
> Key: YARN-7172
> URL: https://issues.apache.org/jira/browse/YARN-7172
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Sen Zhao
> Labels: newbie
> Attachments: YARN-7172.001.patch, YARN-7172.002.patch
>
>
> There are numerous calls to {{ClusterNodeTracker.getClusterResource()}}
> (which involves a lock) to get a value to pass as the cluster resource
> parameter to {{Resources.fitsIn()}}, but the parameter is (quite reasonably)
> ignored. We should remove the parameter.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
