[ 
https://issues.apache.org/jira/browse/YARN-7185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162456#comment-16162456
 ] 

Arun Suresh commented on YARN-7185:
-----------------------------------

Thanks for the patch [~wangda],
In general, it LGTM.
Minor nit though: Can you see if you can add the testcase to 
{{TestContainerSchedulerQueuing}} ?
If the setup/teardown is not too complicated.

> ContainerScheduler should only look at availableResource for GUARANTEED 
> containers when opportunistic scheduling is enabled 
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-7185
>                 URL: https://issues.apache.org/jira/browse/YARN-7185
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: yarn
>            Reporter: Sumana Sathish
>            Assignee: Tan, Wangda
>            Priority: Blocker
>         Attachments: YARN-7185.001.patch, YARN-7185.002.patch, 
> YARN-7185.003.patch
>
>
> Found an issue: 
> When DefaultContainerCalculator is enabled and opportunistic container 
> allocation is disabled. It is possible that for a NM:
> {code} 
> Σ(allocated-container.vcores) > nm.configured-vores. 
> {code} 
> When this happens, ContainerScheduler will report errors like:
> bq. ContainerScheduler 
> (ContainerScheduler.java:pickOpportunisticContainersToKill(458)) - There are 
> no sufficient resources to start guaranteed.
> This will be an incompatible change after 2.8 because before YARN-6706, we 
> can start containers when DefaultContainerCalculator is configured and vcores 
> is overallocated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to