[
https://issues.apache.org/jira/browse/YARN-6726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16163702#comment-16163702
]
Jason Lowe commented on YARN-6726:
----------------------------------
The branch-2 patch also has the off-by-one error in it, see YARN-7014.
{code}
char* input_cpy = malloc(strlen(input));
strcpy(input_cpy, input);
{code}
It also is calling strlen as the condition in a {{for}} loop in the all_numbers
function. This is going to effectively turn it into an O(N^2) operation since
it will have to re-compute the length of the string on every iteration of the
loop. The result of strlen() should be cached in a local variable rather than
called repetitively -- there's no JIT compiler here to clean things up. Looks
like YARN-6852 cleaned that up a bit in trunk.
> Fix issues with docker commands executed by container-executor
> --------------------------------------------------------------
>
> Key: YARN-6726
> URL: https://issues.apache.org/jira/browse/YARN-6726
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Shane Kumpf
> Assignee: Shane Kumpf
> Fix For: 2.9.0, 3.0.0-beta1
>
> Attachments: YARN-6726.001.patch, YARN-6726.002.patch,
> YARN-6726.003.patch
>
>
> docker inspect, rm, stop, etc are issued through container-executor. Commands
> other than docker run are not functioning properly.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
