[
https://issues.apache.org/jira/browse/YARN-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165920#comment-16165920
]
Daniel Templeton commented on YARN-6878:
----------------------------------------
Looks great. One issue:{code} Assert.assertEquals("Available Resource
Memory Size should be 1GB", 0,
availableResource.getMemorySize());
Assert.assertEquals("Available Resource Memory Size should be 1GB", 0,
availableResource.getVirtualCores());{code} The tests and the messages
don't agree on the correct value.
> TestCapacityScheduler.testDefaultNodeLabelExpressionQueueConfig() has the
> args to assertEqual() in the wrong order
> ------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-6878
> URL: https://issues.apache.org/jira/browse/YARN-6878
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, test
> Affects Versions: 3.0.0-alpha4
> Reporter: Daniel Templeton
> Assignee: Sen Zhao
> Priority: Trivial
> Labels: newbie
> Attachments: YARN-6878.001.patch, YARN-6878.002.patch
>
>
> The expected value should come before the actual value. It would be nice to
> add some assert messages as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
