[
https://issues.apache.org/jira/browse/YARN-7034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16167860#comment-16167860
]
Shane Kumpf commented on YARN-7034:
-----------------------------------
Thanks [[email protected]] - The failed test doesn't seem to be
related and is being addressed by YARN-7196. Latest trunk patch looks good to
me. I did notice a couple inconsistencies for the branch-2 and branch-2.8
patches.
branch-2:
1) The executePrivilegedOperation change is missing, below is what is in the
trunk patch, but missing from branch-2:
{code}
public String executePrivilegedOperation(PrivilegedOperation operation,
boolean grabOutput) throws PrivilegedOperationException {
return executePrivilegedOperation(null, operation, null, null, grabOutput,
- true);
+ false);
}
{code}
2) testContainerLaunch() has the unnecessary FROM_CLIENT environment variable
set.
{code}
-
+ env.put("FROM_CLIENT", "1");
+
{code}
3) Privileged is still misspelled in TestLinuxContainerExecutorWithMocks:
{code}
private PrivilegedOperationExecutor mockPriviligedExec;
{code}
branch-2.8:
1) The executePrivilegedOperation change is missing, below is what is in the
trunk patch, but missing from branch-2.8:
{code}
public String executePrivilegedOperation(PrivilegedOperation operation,
boolean grabOutput) throws PrivilegedOperationException {
return executePrivilegedOperation(null, operation, null, null, grabOutput,
- true);
+ false);
}
{code}
2) Privileged is still misspelled in TestLinuxContainerExecutorWithMocks:
{code}
private PrivilegedOperationExecutor mockPriviligedExec;
{code}
> DefaultLinuxContainerRuntime and DockerLinuxContainerRuntime sends client
> environment variables to container-executor
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7034
> URL: https://issues.apache.org/jira/browse/YARN-7034
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Miklos Szegedi
> Assignee: Miklos Szegedi
> Priority: Critical
> Attachments: YARN-7034.000.patch, YARN-7034.001.patch,
> YARN-7034.002.patch, YARN-7034.003.patch, YARN-7034.004.patch,
> YARN-7034.005.patch, YARN-7034.branch-2.000.patch,
> YARN-7034.branch-2.004.patch, YARN-7034.branch-2.005.patch,
> YARN-7034.branch-2.8.000.patch, YARN-7034.branch-2.8.004.patch,
> YARN-7034.branch-2.8.005.patch
>
>
> This behavior is unnecessary since there is nothing that is used from the
> environment right now. One option is to whitelist these variables before
> passing them. Are there any known use cases for this to justify?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
