[ 
https://issues.apache.org/jira/browse/YARN-7199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16168375#comment-16168375
 ] 

Arun Suresh commented on YARN-7199:
-----------------------------------

Thanks for the patch [~botong]. But I think the actual issue is that the 
{{ContainerRequestBuilder#build}} method is not populating the resource profile 
field with the default value {{ProfileCapability.DEFAULT_PROFILE}}. It looks 
the public {{ContainerRequest}} constructors that sets the value correctly - 
unfortunately, the builder uses the private constructor that does not.
The proper fix should be to modify the private constructor to set the value to 
default AND add the resourceProfile() method in the builder, which can be used 
by a client to set it to something else.

> TestAMRMClientContainerRequest.testOpportunisticAndGuaranteedRequests is 
> failing in trunk
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7199
>                 URL: https://issues.apache.org/jira/browse/YARN-7199
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>         Attachments: YARN-7199.v1.patch, YARN-7199.v2.patch
>
>
> java.lang.IllegalArgumentException: The profile name cannot be null
>       at 
> com.google.common.base.Preconditions.checkArgument(Preconditions.java:88)
>       at 
> org.apache.hadoop.yarn.api.records.ProfileCapability.newInstance(ProfileCapability.java:68)
>       at 
> org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl.addContainerRequest(AMRMClientImpl.java:512)
>       at 
> org.apache.hadoop.yarn.client.api.impl.TestAMRMClientContainerRequest.testOpportunisticAndGuaranteedRequests(TestAMRMClientContainerRequest.java:59)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to