[
https://issues.apache.org/jira/browse/YARN-6475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169009#comment-16169009
]
ASF GitHub Bot commented on YARN-6475:
--------------------------------------
GitHub user soumabrata-chakraborty opened a pull request:
https://github.com/apache/hadoop/pull/274
YARN-6475: Refactor long methods in hadoop-yarn-server-nodemanager
Refactor all methods in hadoop-yarn-server-nodemanager that exceed 150
lines in length. Also fixes the method length related Checkstyle violations.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/soumabrata-chakraborty/hadoop branch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/hadoop/pull/274.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #274
----
commit bfdd4cf1e88a6a6e765a7d79297c4d4f288648b4
Author: Soumabrata Chakraborty <[email protected]>
Date: 2017-09-16T18:07:48Z
Refactor code for long methods (above 150 lines in length)
----
> Fix some long function checkstyle issues
> ----------------------------------------
>
> Key: YARN-6475
> URL: https://issues.apache.org/jira/browse/YARN-6475
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Miklos Szegedi
> Assignee: Soumabrata Chakraborty
> Priority: Trivial
> Labels: newbie
> Fix For: 3.0.0-alpha4
>
> Attachments: YARN-6475.001.patch
>
>
> I am talking about these two:
> {code}
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LinuxContainerExecutor.java:441:
> @Override:3: Method length is 176 lines (max allowed is 150). [MethodLength]
> ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/ContainerLaunch.java:159:
> @Override:3: Method length is 158 lines (max allowed is 150). [MethodLength]
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
