[
https://issues.apache.org/jira/browse/YARN-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172660#comment-16172660
]
Yang Wang commented on YARN-6589:
---------------------------------
Thanks for your comment, [~leftnoteasy]
ContainerImpl.java in the trunk has been changed, and i think this bug has been
fixed.
I just update the test.
> Recover all resources when NM restart
> -------------------------------------
>
> Key: YARN-6589
> URL: https://issues.apache.org/jira/browse/YARN-6589
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Yang Wang
> Assignee: Yang Wang
> Priority: Blocker
> Attachments: YARN-6589.001.patch, YARN-6589-YARN-3926.001.patch
>
>
> When NM restart, containers will be recovered. However, only memory and
> vcores in capability have been recovered. All resources need to be recovered.
> {code:title=ContainerImpl.java}
> // resource capability had been updated before NM was down
> this.resource =
> Resource.newInstance(recoveredCapability.getMemorySize(),
> recoveredCapability.getVirtualCores());
> {code}
> It should be like this.
> {code:title=ContainerImpl.java}
> // resource capability had been updated before NM was down
> // need to recover all resources, not only <mem, vcores>
> this.resource = Resources.clone(recoveredCapability);
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
