[
https://issues.apache.org/jira/browse/YARN-6968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16173898#comment-16173898
]
Miklos Szegedi commented on YARN-6968:
--------------------------------------
Thank you, [~ebadger] for the patch and [~jlowe] for the review.
+1 (non-binding) with the notes below.
Just a note that this will be a bit of a regression, since /sys/fs/cgroup is
not default anymore.
I suggest opening the following followup jiras:
Make Docker target directory configurable in yarn-site.xml.
Check, if we need to default to /sys/fs/cgroup. This is non trivial in older
OSes where cgroup can be mounted by the admins, although probably those do not
support Docker.
A general jira to discuss whether mounting is needed for all cases and it could
be turned off by default.
Let me know, if you disagree.
> Hardcoded absolute pathname in DockerLinuxContainerRuntime
> ----------------------------------------------------------
>
> Key: YARN-6968
> URL: https://issues.apache.org/jira/browse/YARN-6968
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Reporter: Miklos Szegedi
> Assignee: Eric Badger
> Attachments: YARN-6968.001.patch, YARN-6968.002.patch,
> YARN-6968.003.patch, YARN-6968.004.patch
>
>
> org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.runtime.DockerLinuxContainerRuntime.launchContainer(ContainerRuntimeContext)
> has a hardcoded absolute pathname that is being flagged by findbugs.
> This could be done after YARN-6757 is checked in.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
