[
https://issues.apache.org/jira/browse/YARN-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177224#comment-16177224
]
Wangda Tan commented on YARN-2497:
----------------------------------
[~templedf],
I just took a quick look at your patch, some minor comments:
1) Changes to NodeLabel.NODE_LABEL_EXPRESSION_NOT_SET:
Previously this changes is for human readability, because when label is not set
for app (<NOT_SET>), scheduler could use queue's default-node-label-expression
to override the value. So change this to an empty breaks original use cases.
Probably we should rename it:
- NODE_LABEL_EXPRESSION_NOT_SET => NODE_LABEL_EXPRESSION_NOT_SET_FOR_DIAGNOSTICS
- DEFAULT_NODE_LABEL_PARTITION => DEFAULT_NODE_LABEL_PARTITION_FOR_DIAGNOSTICS
- RMApp#getAppNodeLabelExpression => getAppNodeLabelExpressionForDiagnostics /
getAmNodeLabelExpression => getAmNodeLabelExpressionForDiagnostics
- And the changes of getAmNodeLabelExpression is a behavior change, which
removed original DEFAULT_NODE_LABEL_EXPRESSION.
Please let me know if you have any thoughts here.
2) RMNodeLabelsManager:
- acceptAny should be visibleByTest.
3) SchedulerAppAttempt:
- In hasPendingResourceRequest:
{code}
if (Resources.greaterThan(rc, cluster, pending, Resources.none())) {
return true;
}
return false;
{code}
Cannot be replaced by
{{!Resources.isNone(pending)}}
Because when DefaultResourceCalculator is configured, we won't continue
allocate resource even if we have positive pending #vcores.
> Changes for fair scheduler to support allocate resource respect labels
> ----------------------------------------------------------------------
>
> Key: YARN-2497
> URL: https://issues.apache.org/jira/browse/YARN-2497
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Wangda Tan
> Assignee: Daniel Templeton
> Attachments: YARN-2497.001.patch, YARN-2497.002.patch,
> YARN-2497.003.patch, YARN-2499.WIP01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
