[ 
https://issues.apache.org/jira/browse/YARN-6509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16177580#comment-16177580
 ] 

Junping Du commented on YARN-6509:
----------------------------------

Thanks [~xgong] for updating the patch. v3 patch looks good to me in overall. 
Only one concern here is: shall we make 10G default size to be configurable? If 
not, in future it will be incompatible change when we want to update this value 
to something different - unless we are quite confident on this value.
 Another minor issue is we should keep consistent of using "limit" instead of 
"limits" in naming and printed messages.
Other looks fine to me.

> Add a size threshold beyond which yarn logs will require a force option
> -----------------------------------------------------------------------
>
>                 Key: YARN-6509
>                 URL: https://issues.apache.org/jira/browse/YARN-6509
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Siddharth Seth
>            Assignee: Xuan Gong
>             Fix For: 2.9.0
>
>         Attachments: YARN-6509.1.patch, YARN-6509.2.patch, YARN-6509.3.patch
>
>
> An accidental fetch for a long running application can lead to scenario which 
> the large size of log can fill up a disk.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to