[ 
https://issues.apache.org/jira/browse/YARN-7244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16180516#comment-16180516
 ] 

Bibin A Chundatt commented on YARN-7244:
----------------------------------------


Thank you [~kshukla] for patch.  Minor comments from my side
#  Better to check directory exists first if we are not concerned of permission 
. thoughts?
{code}
348           if (ctx.localFS.mkdirs(tmpDir) || ctx.localFS.exists(tmpDir))
{code}
# Testcase is successful even if  YARN_SHUFFLE_BAD_DIRS_FILTER_ENABLED set to 
false.
{code}
    conf.setBoolean(
        YarnConfiguration.YARN_SHUFFLE_BAD_DIRS_FILTER_ENABLED, false);
{code}

> ShuffleHandler is not aware of disks that are added
> ---------------------------------------------------
>
>                 Key: YARN-7244
>                 URL: https://issues.apache.org/jira/browse/YARN-7244
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Kuhu Shukla
>            Assignee: Kuhu Shukla
>         Attachments: YARN-7244.001.patch, YARN-7244.002.patch
>
>
> The ShuffleHandler permanently remembers the list of "good" disks on NM 
> startup. If disks later are added to the node then map tasks will start using 
> them but the ShuffleHandler will not be aware of them. The end result is that 
> the data cannot be shuffled from the node leading to fetch failures and 
> re-runs of the map tasks.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to