[
https://issues.apache.org/jira/browse/YARN-7202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181706#comment-16181706
]
Eric Yang commented on YARN-7202:
---------------------------------
[~jianhe] The test case are designed to be unit tests for ApiServer without
over reaching. It also covers the input validation in ServiceClient. It is
possible to write additional tests to focus on ServiceClient correctness which
can increase test coverage. However, I think it is easy to mistaken unit test
verse integration test. Without good coverage at interface level, integration
test may not help to identify the root problems. I can't say I am familiar
with ServiceClient code to write unit tests for it. I can write unit tests for
new code that I am about to add to ServiceClient for storing Service config.
However, it would be helpful for original author who wrote ServiceClient to add
test code.
> End-to-end UT for api-server
> ----------------------------
>
> Key: YARN-7202
> URL: https://issues.apache.org/jira/browse/YARN-7202
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Eric Yang
> Attachments: YARN-7202.yarn-native-services.001.patch,
> YARN-7202.yarn-native-services.002.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
