[
https://issues.apache.org/jira/browse/YARN-2162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16182401#comment-16182401
]
Daniel Templeton commented on YARN-2162:
----------------------------------------
Thanks, [~yufeigu]. New comments:
# Mind the checkstyle issues.
# Since you're storing the min and max as variables in
{{checkMinAndMaxResource()}}, you may as well put them outside the _if_ so you
can check them for null instead of using {{contains()}}.
# The {{Pattern}} in {{findPercentage()}} should be a constant.
# {{TestConfigurableResource}} needs assert messages, especially on the
{{assertNull()}} calls.
# {{ConfigurableResource}} needs javadoc. Be sure to explain in the
{{getResource()}} docs what happens when you pass it {{null}}.
I'm still worried about performance impact of the new {{getMaxShare()}}. Let's
be sure to test it thoughtfully.
> add ability in Fair Scheduler to optionally configure maxResources in terms
> of percentage
> -----------------------------------------------------------------------------------------
>
> Key: YARN-2162
> URL: https://issues.apache.org/jira/browse/YARN-2162
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler, scheduler
> Reporter: Ashwin Shankar
> Assignee: Yufei Gu
> Labels: scheduler
> Attachments: YARN-2162.001.patch, YARN-2162.002.patch,
> YARN-2162.003.patch, YARN-2162.004.patch, YARN-2162.005.patch,
> YARN-2162.006.patch
>
>
> minResources and maxResources in fair scheduler configs are expressed in
> terms of absolute numbers X mb, Y vcores.
> As a result, when we expand or shrink our hadoop cluster, we need to
> recalculate and change minResources/maxResources accordingly, which is pretty
> inconvenient.
> We can circumvent this problem if we can optionally configure these
> properties in terms of percentage of cluster capacity.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
