[
https://issues.apache.org/jira/browse/YARN-7248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16183279#comment-16183279
]
Jason Lowe commented on YARN-7248:
----------------------------------
Thanks for updating the patch! I believe the unit test failures are
pre-existing.
EXTRA_STATE_INFO is no longer needed in ContainerStatePBImpl.
CONTAINER_SUB_STATE_PREFIX should be final.
convertFromProtoFormat(ContainerSubStateProto) should not blindly call String
replace since that could inadvertently replace _any_ occurrence in the string
when we clearly only want the first part of the string replaced. It would be
more correct and much more efficient to use
e.name().substring(CONTAINER_SUB_STATE_PREFIX.length()) instead.
Nit: If there are going to be comments in the proto files and the
ContainerSubState enum on how internal states are mapped then there should be a
comment in getContainerSubState reminding others to keep those comments in sync
with that method.
Nit: Would be nice to fix the indentation nits identified in checkstyle so the
new getContainerSubState formatting is consistent with the existing
getContainerState method.
> NM returns new SCHEDULED container status to older clients
> ----------------------------------------------------------
>
> Key: YARN-7248
> URL: https://issues.apache.org/jira/browse/YARN-7248
> Project: Hadoop YARN
> Issue Type: Bug
> Components: nodemanager
> Affects Versions: 2.9.0, 3.0.0-alpha2
> Reporter: Jason Lowe
> Assignee: Arun Suresh
> Priority: Blocker
> Attachments: YARN-7248.001.patch, YARN-7248.002.patch
>
>
> YARN-4597 added a new SCHEDULED container state and that state is returned to
> clients when the container is localizing, etc. However the client may be
> running on an older software version that does not have the new SCHEDULED
> state which could lead the client to crash on the unexpected container state
> value or make incorrect assumptions like any state != NEW and != RUNNING must
> be COMPLETED which was true in the older version.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
