[
https://issues.apache.org/jira/browse/YARN-2497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16189149#comment-16189149
]
Wangda Tan commented on YARN-2497:
----------------------------------
Thanks [~templedf] for updating the patch, patch looks good to me in general,
few minor suggestions:
Remove unused method of Resources:
{code}
public static boolean isAnyMajorResourceNonZero(ResourceCalculator rc,
Resource resource) {
return rc.isAnyMajorResourceNonZero(resource);
}
{code}
Naming:
- getAppNodeLabelExpression -> getAppNodeLabelExpressionForDisplay
- getAmNodeLabelExpression -> getAmNodeLabelExpressionForDisplay
> Changes for fair scheduler to support allocate resource respect labels
> ----------------------------------------------------------------------
>
> Key: YARN-2497
> URL: https://issues.apache.org/jira/browse/YARN-2497
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: fairscheduler
> Reporter: Wangda Tan
> Assignee: Daniel Templeton
> Attachments: YARN-2497.001.patch, YARN-2497.002.patch,
> YARN-2497.003.patch, YARN-2497.004.patch, YARN-2497.005.patch,
> YARN-2497.006.patch, YARN-2497.007.patch, YARN-2497.008.patch,
> YARN-2497.009.patch, YARN-2499.WIP01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
