[ 
https://issues.apache.org/jira/browse/YARN-7311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16202833#comment-16202833
 ] 

Yufei Gu commented on YARN-7311:
--------------------------------

Uploaded patch v1. What I did in it:
- Make tests really test for fair scheduler. 
- Fix the queue name bug in reservation system for fair scheduler.
- Fix the fair scheduler configuration issue in the test.

> TestRMWebServicesReservation doesn't really test fair scheduler
> ---------------------------------------------------------------
>
>                 Key: YARN-7311
>                 URL: https://issues.apache.org/jira/browse/YARN-7311
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: fairscheduler, reservation system
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-7311.001.patch, YARN-7311.WIP.patch
>
>
> YARN-4248 introduced the REST API for submit/update/delete Reservations. 
> Class {{TestRMWebServicesReservation}} intends to test both FS and CS. The 
> test cases designed for fair scheduler actually test capacity scheduler. The 
> following code in method {{configureServlets}} shows it sets the scheduler to 
> CS even test cases are for fair scheduler.
> {code}
>       conf.setClass(YarnConfiguration.RM_SCHEDULER, CapacityScheduler.class,
>           ResourceScheduler.class);
>       CapacitySchedulerConfiguration csconf =
>           new CapacitySchedulerConfiguration(conf);
>       String[] queues = { "default", "dedicated" };
>       csconf.setQueues("root", queues);
>       csconf.setCapacity("root.default", 50.0f);
>       csconf.setCapacity("root.dedicated", 50.0f);
>       csconf.setReservable("root.dedicated", true);
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to