[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karthik Kambatla updated YARN-353:
----------------------------------
Attachment: yarn-353-12-wip.patch
While looking into the findbugs issue, noticed that there was a potential bug
in ZKAction implementation.
In YARN-353.11.patch and other previous patches, ZKAction has a local copy of
zkClient. If this zkClient is null, it waits for createConnection() to connect.
However, this local copy is not updated, making the wait-notify between
ZKAction#runWithCheck and createConnection moot.
Posting a wip patch (haven't tested it on a cluster yet) that
# gets rid of the local variables in ZKAction
# adds synchronization around the wait in ZKAction#runWithCheck()
# moves zkDoWithRetries to ZKAction#runWithRetries
With this patch, there was no need to exclude findbugs warnings. Verified
TestRMRestart passes.
> Add Zookeeper-based store implementation for RMStateStore
> ---------------------------------------------------------
>
> Key: YARN-353
> URL: https://issues.apache.org/jira/browse/YARN-353
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Hitesh Shah
> Assignee: Bikas Saha
> Attachments: YARN-353.10.patch, YARN-353.11.patch,
> yarn-353-12-wip.patch, YARN-353.1.patch, YARN-353.2.patch, YARN-353.3.patch,
> YARN-353.4.patch, YARN-353.5.patch, YARN-353.6.patch, YARN-353.7.patch,
> YARN-353.8.patch, YARN-353.9.patch
>
>
> Add store that write RM state data to ZK
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
