[ 
https://issues.apache.org/jira/browse/YARN-7066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204612#comment-16204612
 ] 

Shane Kumpf edited comment on YARN-7066 at 10/14/17 12:51 PM:
--------------------------------------------------------------

[~eyang] thanks for the updated patch. I'm still confused as to what this is 
providing over YARN-5534. Both support the user supplying mounts via an 
environment variable, which then gets added to the {{docker run}} command. The 
only difference for that piece is the format of the user supplied environment 
variable, but YARN-5534 goes a step further to attempt to validate the mount is 
also in the white list. I reread your comment about why you feel the approach 
used by this patch is superior, but I'm not following what you mean.


was (Author: shaneku...@gmail.com):
[~eyang] thanks for the updated patch. I'm still confused as to what this is 
providing over YARN-5534. Both support the user supplying mounts via an 
environment variable, which then gets added to the {{docker run}} command. The 
only difference for that piece is the format of the user supplied environment 
variable, but YARN-5534 goes a step further to attempt to validate the mount is 
also in the white list. I reread your comment about why you feel this approach 
is superior, but I'm not following what you mean.

> Add ability to specify volumes to mount for DockerContainerRuntime
> ------------------------------------------------------------------
>
>                 Key: YARN-7066
>                 URL: https://issues.apache.org/jira/browse/YARN-7066
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn-native-services
>    Affects Versions: 3.0.0-beta1
>            Reporter: Eric Yang
>         Attachments: YARN-7066.001.patch, YARN-7066.002.patch
>
>
> Yarnfile describes environment, docker image, and configuration template for 
> launching docker containers in YARN.  It would be nice to have ability to 
> specify the volumes to mount.  This can be used in combination to 
> AMBARI-21748 to mount HDFS as data directories to docker containers.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

Reply via email to