[ 
https://issues.apache.org/jira/browse/YARN-7261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212189#comment-16212189
 ] 

Xiao Chen commented on YARN-7261:
---------------------------------

Thanks for revving Yufei!

1 minor comment:
{code}
if (LOG.isDebugEnabled()) {
    LOG.debug("Skip downloading resource: " + key + " since it isn't"
        + " ready or it has been downloaded.");
}
{code}
Let's also add {{rsrc.getState()}} to this message. We can say {{"since it's in 
state: " + rsrc.getState()}}.

+1 pending that and pre-commit.

> Add debug message in class FSDownload for better download latency monitoring
> ----------------------------------------------------------------------------
>
>                 Key: YARN-7261
>                 URL: https://issues.apache.org/jira/browse/YARN-7261
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: Yufei Gu
>            Assignee: Yufei Gu
>         Attachments: YARN-7261.001.patch, YARN-7261.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to