[ 
https://issues.apache.org/jira/browse/YARN-7339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217365#comment-16217365
 ] 

Carlo Curino commented on YARN-7339:
------------------------------------

Thanks [~botong] for the contribution. Per our offline discussion, I agree with 
the fix and the patch LGTM. 
Given the happy yetus I am committing this to trunk and branch-3.0. 

The patch doesn't apply cleanly to branch-2 can you please check what is the 
issues (likely minor). 
Please upload a patch for branch-2 ASAP as the release 2.9 is being cut from 
this very soon.

> LocalityMulticastAMRMProxyPolicy should handle cancel request properly
> ----------------------------------------------------------------------
>
>                 Key: YARN-7339
>                 URL: https://issues.apache.org/jira/browse/YARN-7339
>             Project: Hadoop YARN
>          Issue Type: Bug
>            Reporter: Botong Huang
>            Assignee: Botong Huang
>            Priority: Minor
>         Attachments: YARN-7339-v1.patch, YARN-7339-v2.patch, 
> YARN-7339-v3.patch, YARN-7339-v4.patch, YARN-7339-v5.patch, YARN-7339-v6.patch
>
>
> Currently inside AMRMProxy, LocalityMulticastAMRMProxyPolicy is not handling 
> and splitting cancel requests from AM properly: 
> # For node cancel request, we should not treat it as a localized resource 
> request. Otherwise it can lead to all weight zero issue when computing 
> localized resource weight. 
> # For ANY cancel, we should broadcast to all known subclusters, not just the 
> ones associated with localized resources. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to