[
https://issues.apache.org/jira/browse/YARN-7336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217737#comment-16217737
]
Daniel Templeton commented on YARN-7336:
----------------------------------------
LGTM. Can we do anything about the ugly hash method in
{{LightWeightResource}}? Seems like the way we build up result is kinda goofy.
Looks like there used to be a loop there that was removed or some such.
> Unsafe cast from long to int Resource.hashCode() method
> -------------------------------------------------------
>
> Key: YARN-7336
> URL: https://issues.apache.org/jira/browse/YARN-7336
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 3.0.0-beta1, 3.1.0
> Reporter: Daniel Templeton
> Assignee: Miklos Szegedi
> Priority: Critical
> Attachments: YARN-7336.000.patch
>
>
> For example:
> {code}
> final int prime = 47;
> long result = 0;
> for (ResourceInformation entry : resources) {
> result = prime * result + entry.hashCode();
> }
> return (int) result;
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
