[ 
https://issues.apache.org/jira/browse/YARN-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218311#comment-16218311
 ] 

Sunil G commented on YARN-7159:
-------------------------------

bq.Based on my understaning, it has two parts. 1) Changes in 
ResourceInformation#copy 2)Changes in ResourceInformation#setUnits. #2 changes 
would be something like

I think ResourceInformation#copy could invoke 
ResourceInformation#setUnitsWithoutChecking.
Then ResourceInformation#setUnits could be similar to  your code snipper which 
u gave above. 

> Normalize unit of resource objects in RM and avoid to do unit conversion in 
> critical path
> -----------------------------------------------------------------------------------------
>
>                 Key: YARN-7159
>                 URL: https://issues.apache.org/jira/browse/YARN-7159
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: nodemanager, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-7159.001.patch, YARN-7159.002.patch
>
>
> Currently resource conversion could happen in critical code path when 
> different unit is specified by client. This could impact performance and 
> throughput of RM a lot. We should do unit normalization when resource passed 
> to RM and avoid expensive unit conversion every time.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to