[ https://issues.apache.org/jira/browse/YARN-7276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219617#comment-16219617 ]
Giovanni Matteo Fumarola commented on YARN-7276: ------------------------------------------------ Thanks [~elgoiri] for the patch. It looks good, couple of nits: * Typo in {{routerWebService.replaceLabelsOnNode}} should be {{routerWebService.replaceLabelsOnNodes}}; * Typo in {{routerWebService.removeFromCluserNodeLabels}} should be {{routerWebService.addToClusterNodeLabels}}; * Rename {{testMultiThread}} --> {{testGetAppsMultiThread}}. > Federation Router Web Service fixes > ----------------------------------- > > Key: YARN-7276 > URL: https://issues.apache.org/jira/browse/YARN-7276 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Íñigo Goiri > Assignee: Íñigo Goiri > Attachments: YARN-7276-branch-2.000.patch, > YARN-7276-branch-2.001.patch, YARN-7276-branch-2.002.patch, > YARN-7276-branch-2.003.patch, YARN-7276-branch-2.004.patch, > YARN-7276.000.patch, YARN-7276.001.patch, YARN-7276.002.patch, > YARN-7276.003.patch, YARN-7276.004.patch, YARN-7276.005.patch, > YARN-7276.006.patch, YARN-7276.007.patch, YARN-7276.009.patch, > YARN-7276.010.patch > > > While testing YARN-3661, I found a few issues with the REST interface in the > Router: > * No support for empty content (error 204) > * Media type support > * Attributes in {{FederationInterceptorREST}} > * Support for empty states and labels > * DefaultMetricsSystem initialization is missing -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org