[
https://issues.apache.org/jira/browse/YARN-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16222740#comment-16222740
]
Miklos Szegedi commented on YARN-1015:
--------------------------------------
Thank you for the patch [~haibochen].
{code}
271 public static final boolean
DEFAULT_RM_SCHEDULER_OVERSUBSCRIPTION_ENABLED
272 = true;
{code}
I think the default should be false.
{code}
385 If set to true, the scheduler will try to over-allocate resources
on
386 the nodes that allow overallocation.
{code}
Could you be more specific here? It is unclear to me based on this description,
how a node allows overallocation.
{{max_radio}} this is a typo.
{code}
322 ", ResourceUsage: " + getGuaranteedResourceUsage() +
{code}
Please label this as Guaranteed resource usage.
{code}
1049 //&& !assignment.equals(CONTAINER_RESERVED)) {
1050 // assigned can be FS.CONTAINER_RESERVED
1051 // should we count it as an assignment?
{code}
This commented code should be removed, if not needed anymore.
{code}
317 containerUpdates = new ArrayList<>(1);
318 containerUpdates.add(updatedContainerInfo);
{code}
How about Lists.newArrayList?
{code}
116 return usage;
{code}
It might make sense to name this guaranteedUsage
> FS should watch node resource utilization and allocate opportunistic
> containers if appropriate
> ----------------------------------------------------------------------------------------------
>
> Key: YARN-1015
> URL: https://issues.apache.org/jira/browse/YARN-1015
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Arun C Murthy
> Assignee: Haibo Chen
> Attachments: YARN-1015-YARN-1011.prelim.patch
>
>
> FS should looks at resource utilization of nodes (provided by NM in
> heartbeat) and allocate opportunistic containers if the resource utilization
> of the node is below its allocation threshold.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
