[
https://issues.apache.org/jira/browse/YARN-7390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227136#comment-16227136
]
Haibo Chen commented on YARN-7390:
----------------------------------
Thanks @Yufei for the update!
1) testAMRMToken() should probably call getConf() in cluster.init() as well,
otherwise it is still just testing with capacity scheduler.
2) configureReservationForFairScheduler() swallows IOException when writing
the allocation file, making it harder to debug.
Can we just throw IOException at the method signature and fail fast? ()
3) Some unit test methods use conf from ParameterizedSchedulerTestBase, whereas
all reservation-based ones use a new
configuration from setMiniYarnCluster. Do you think it is cleaner to have
another class that contains all reservation-based
tests and the existing TestYarnClient just have the rest?
> All reservation related test cases failed when TestYarnClient runs against
> Fair Scheduler.
> ------------------------------------------------------------------------------------------
>
> Key: YARN-7390
> URL: https://issues.apache.org/jira/browse/YARN-7390
> Project: Hadoop YARN
> Issue Type: Bug
> Components: fairscheduler, reservation system
> Affects Versions: 2.9.0, 3.0.0, 3.1.0
> Reporter: Yufei Gu
> Assignee: Yufei Gu
> Attachments: YARN-7390.001.patch, YARN-7390.002.patch
>
>
> All reservation related test cases failed when {{TestYarnClient}} runs
> against Fair Scheduler. To reproduce it, you need to set scheduler class to
> Fair Scheduler in yarn-default.xml.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
