[
https://issues.apache.org/jira/browse/YARN-7370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227276#comment-16227276
]
Eric Payne commented on YARN-7370:
----------------------------------
[~GergelyNovak], Thanks for the updated patch. Just a couple of things:
- Why were {{DEFAULT_PREEMPTION_MAX_IGNORED_OVER_CAPACITY}} and
{{DEFAULT_PREEMPTION_NATURAL_TERMINATION_FACTOR}} changed from float to double?
The capacity scheduler configuration properties are not consistent about the
usage of float and double, but it looks like the preemption properties are
using float. If we want to make it consistent or change these to double, I
would prefer to do it as a separate JIRA.
- Thanks for adding the log documenting the updated properties. Can you please
add the following properties to the log statement?
-- isIntraQueuePreemptionEnabled
-- selectCandidatesForResevedContainers
-- isQueuePriorityPreemptionEnabled
-- additionalPreemptionBasedOnReservedResource
> Preemption properties should be refreshable
> -------------------------------------------
>
> Key: YARN-7370
> URL: https://issues.apache.org/jira/browse/YARN-7370
> Project: Hadoop YARN
> Issue Type: Bug
> Components: capacity scheduler, scheduler preemption
> Affects Versions: 2.8.0, 3.0.0-alpha3
> Reporter: Eric Payne
> Assignee: Gergely Novák
> Attachments: YARN-7370.001.patch, YARN-7370.002.patch
>
>
> At least the properties for {{max-allowable-limit}} and {{minimum-threshold}}
> should be refreshable. It would also be nice to make
> {{intra-queue-preemption.enabled}} and {{preemption-order-policy}}
> refreshable.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
