[
https://issues.apache.org/jira/browse/YARN-7411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227652#comment-16227652
]
Wangda Tan commented on YARN-7411:
----------------------------------
Thanks [~sunilg] for working on this, approach looks good to me.
Besides UT failures / findbugs warnings, one comment on code:
For {{getMinResourceNormalized}}, I'm not sure if it works when #resources >=
2.
Do you think we should remove {{Resource stepFactor}} from param list since it
is always 1?
And I think we need add more UTs for this, correct?
> Inter-Queue preemption's computeFixpointAllocation need to handle absolute
> resources while computing normalizedGuarantee
> ------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-7411
> URL: https://issues.apache.org/jira/browse/YARN-7411
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: YARN-5881
> Reporter: Sunil G
> Assignee: Sunil G
> Attachments: YARN-7411.001.patch
>
>
> {{normalizedGuarantee}} is computed based on queue's capacity. This has to be
> updated correctly when CS starts to accept queue's capacity in terms of
> absolute resource.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
