[
https://issues.apache.org/jira/browse/YARN-7423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238429#comment-16238429
]
Billie Rinaldi commented on YARN-7423:
--------------------------------------
The patch looks good overall. The logging when persisting a service should
happen for create and build, but I think it only happens for create after this
patch. You could move the log statement to createDirAndPersistApp, or just
repeat the log statement in the actionBuild method. I noticed actionStart is
calling createDirAndPersistApp, but it could probably just call persistAppDef
since the directory must already be created before start is called.
> Improve service client loggings
> -------------------------------
>
> Key: YARN-7423
> URL: https://issues.apache.org/jira/browse/YARN-7423
> Project: Hadoop YARN
> Issue Type: Sub-task
> Reporter: Jian He
> Assignee: Jian He
> Priority: Major
> Fix For: yarn-native-services
>
> Attachments: YARN-7423.yarn-native-services.01.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
