[
https://issues.apache.org/jira/browse/YARN-7414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242510#comment-16242510
]
Daniel Templeton edited comment on YARN-7414 at 11/7/17 5:50 PM:
-----------------------------------------------------------------
Looks good. I only have 2 tiny quibbles:
# Extra blank line on L1307
# {{this.}} isn't needed on L1315
was (Author: templedf):
Looks good. I only have 2 tiny quibbles:
# # Extra blank line on L1307
# {{this.}} isn't needed on L1315
> FairScheduler#getAppWeight() should be moved into FSAppAttempt#getWeight()
> --------------------------------------------------------------------------
>
> Key: YARN-7414
> URL: https://issues.apache.org/jira/browse/YARN-7414
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: fairscheduler
> Affects Versions: 3.0.0-beta1
> Reporter: Daniel Templeton
> Assignee: Soumabrata Chakraborty
> Priority: Minor
> Labels: newbie
> Attachments: YARN-7414.001.patch
>
>
> It's illogical that {{FSAppAttempt}} defers to {{FairScheduler}} for its own
> weight, especially when {{FairScheduler}} has to call back to
> {{FSAppAttempt}} to get the details to return a value. Instead,
> {{FSAppAttempt}} should do the work and call out to {{FairScheduler}} to get
> the details it needs.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
