[
https://issues.apache.org/jira/browse/YARN-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244226#comment-16244226
]
Jason Lowe commented on YARN-7458:
----------------------------------
Thanks for the patch!
If the container never completes then the method just moves on as if it did.
Shouldn't it throw? Assuming it should, GenericTestUtils.waitFor seems
appropriate here.
Nit: I'm never a fan of 1 second sleeps in tests (or sleeps at all if we can
avoid it). It's almost always overkill and makes the test slower than it needs
to be. If a test had to wait for 10 containers to complete serially that's 10
seconds of wasted test time. I'd change this to at most 100msec, probably just
10msec.
> TestContainerManagerSecurity is still flakey
> --------------------------------------------
>
> Key: YARN-7458
> URL: https://issues.apache.org/jira/browse/YARN-7458
> Project: Hadoop YARN
> Issue Type: Bug
> Components: test
> Affects Versions: 2.9.0, 3.0.0-beta1
> Reporter: Robert Kanter
> Assignee: Robert Kanter
> Attachments: YARN-7458.001.patch
>
>
> YARN-6150 made this less flakey, but we're still seeing an occasional issue
> here:
> {noformat}
> java.lang.NullPointerException
> at
> org.apache.hadoop.yarn.server.TestContainerManagerSecurity.waitForContainerToFinishOnNM(TestContainerManagerSecurity.java:420)
> at
> org.apache.hadoop.yarn.server.TestContainerManagerSecurity.testNMTokens(TestContainerManagerSecurity.java:356)
> at
> org.apache.hadoop.yarn.server.TestContainerManagerSecurity.testContainerManager(TestContainerManagerSecurity.java:167)
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
