[ 
https://issues.apache.org/jira/browse/YARN-7454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245911#comment-16245911
 ] 

Hudson commented on YARN-7454:
------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13210 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/13210/])
YARN-7454. RMAppAttemptMetrics#getAggregateResourceUsage can NPE due to 
(bibinchundatt: rev 0a72c2f56c37063609de72eef1f74632890c048a)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/RMAppAttemptMetrics.java


> RMAppAttemptMetrics#getAggregateResourceUsage can NPE due to double lookup
> --------------------------------------------------------------------------
>
>                 Key: YARN-7454
>                 URL: https://issues.apache.org/jira/browse/YARN-7454
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.1.0
>            Reporter: Jason Lowe
>            Assignee: Jason Lowe
>            Priority: Minor
>             Fix For: 3.0.0, 3.1.0
>
>         Attachments: YARN-7454.001.patch
>
>
> RMAppAttemptMetrics#getAggregateResourceUsage does a double-lookup on a 
> concurrent hash map, but the app could be removed from the map between the 
> two lookups:
> {code}
>     RMApp rmApp = rmContext.getRMApps().get(attemptId.getApplicationId());
>     if (rmApp != null) {
>       RMAppAttempt currentAttempt = 
> rmContext.getRMApps().get(attemptId.getApplicationId()).getCurrentAppAttempt();
> {code}
> The attempt should be looked up within rmApp directly rather than redundantly 
> trying to retrieve the RMApp first.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to