[
https://issues.apache.org/jira/browse/YARN-7119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246731#comment-16246731
]
Daniel Templeton commented on YARN-7119:
----------------------------------------
I have just a few comments:
# The new public methods in {{ResourceUtils}} should have javadocs.
# RMAdminCLI:L290, it would be nice to move the + from the end of L289 to the
beginning of L290.
# Javadocs on {{handleUpdateNodeResource()}} are incomplete (params, etc.)
# RMAdminCLI:L956,L958, The {{Pattern.matcher()}} call should be cached instead
of repeated since it's a relatively expensive operation.
# RMAdminCLI:L973, "csv" is actually the wrong term. CSV != comma-delimited
# TestRMAdminCLI:L643-644, looks like you left in some commented-out code
# You should update the CLI docs as well
> yarn rmadmin -updateNodeResource should be updated for resource types
> ---------------------------------------------------------------------
>
> Key: YARN-7119
> URL: https://issues.apache.org/jira/browse/YARN-7119
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: nodemanager, resourcemanager
> Affects Versions: YARN-3926
> Reporter: Daniel Templeton
> Assignee: Manikandan R
> Attachments: YARN-7119.001.patch, YARN-7119.002.patch,
> YARN-7119.002.patch, YARN-7119.003.patch, YARN-7119.004.patch,
> YARN-7119.004.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
